Just realized my comments were way too long for code reviews

A senior dev pulled me aside last month. Said my code reviews looked like short stories. He told me to focus on one issue per comment, no explanations unless asked. I cut my reviews from 10 sentences to 2-3. Got way more of my suggestions actually tried after that. Anyone else get feedback that made you totally change how you give input?

3 comments

3 Comments

verab281mo ago

Has anyone else had that moment where you realize less really is more with feedback? I totally get what you mean, and kudos to that senior dev for steering you right. It's amazing how much easier it is to get someone to listen when you just say the main point and stop. I've seen it happen at my own work too - people glaze over if you write too much. What Nathan Bailey said about short and direct hitting harder is spot on. It's not about being rude, it's about being clear and respectful of everyone's time.

nora101mo ago

Oh PLEASE, it's just code feedback, not brain surgery, calm down.

nathan_bailey1mo ago

Honestly, that's solid advice. Short and direct hits way harder than a paragraph nobody reads. Senior dev basically taught you how to get actual results instead of just making noise.