A senior dev told me to stop 'fixing' code and I'm still salty about it

I spent 3 months refactoring my project's login flow to use clean classes and design patterns. My senior dev looked at it and said 'you turned 200 lines into 600 lines for no reason, just revert it.' He was right though. My code worked but nobody else on the team could read it, and I had to walk everyone through it twice. Since then I write boring, simple functions that match the codebase style even if it's ugly. Has anyone else had their 'clever' code shut down, and did you push back or just accept it?

1 comments

Log in to join the discussion

Log In

1 Comment

reese17722d ago

Did you try explaining why the original was hard to work with, or did you just take the L? I've been there too, and honestly the boring fix usually wins because no one wants to be the one who has to debug it at 2am when it breaks.

5